Fix testcases for proj2

- Fix possible race on child-rox - Change multi-oom timeout to 600 (those who do slow implementation).
pintOS-Team2 · Apr 19, 2020 · 8906e08 · 8906e08
1 parent 7794ae3
commit 8906e08
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/tests/userprog/child-rox.c b/tests/userprog/child-rox.c
@@ -42,10 +42,13 @@ main (int argc UNUSED, char *argv[])
       int child;
 
       snprintf (cmd, sizeof cmd, "child-rox %d", atoi (argv[1]) - 1);
+      msg ("exec \"%s\"", cmd);
       if (!(child = fork ("child-rox"))){
         exec (cmd);
       }
-      CHECK (child != -1, "exec \"%s\"", cmd);
+
+      if (child < 0)
+        fail ("fork() returned %d", child);
       quiet = true;
       CHECK (wait (child) == 12, "wait for \"child-rox\"");
       quiet = false;

diff --git a/tests/userprog/no-vm/Make.tests b/tests/userprog/no-vm/Make.tests
@@ -5,4 +5,4 @@ tests/userprog/no-vm_PROGS = $(tests/userprog/no-vm_TESTS)
 tests/userprog/no-vm/multi-oom_SRC = tests/userprog/no-vm/multi-oom.c	\
 tests/lib.c
 
-tests/userprog/no-vm/multi-oom.output: TIMEOUT = 360 -m 20
+tests/userprog/no-vm/multi-oom.output: TIMEOUT = 600 -m 20