Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop lager dependency #218

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Drop lager dependency #218

merged 1 commit into from
Nov 29, 2021

Conversation

jparise
Copy link
Collaborator

@jparise jparise commented Nov 26, 2021

This was previously used to manage log output from Erlang :error_logger.
It may have also been a dependency of exometer_core at some point in the
past, but I couldn't find a reference to it after some brief searching.

Either way, :logger itself does the same job without the additional
dependency.

Fixes #217

@jparise jparise requested a review from fishcakez November 26, 2021 17:18
@jparise jparise added the dependencies Pull requests that update a dependency file label Nov 26, 2021
@jparise jparise force-pushed the drop-lager branch 2 times, most recently from f6c833c to bff69e1 Compare November 26, 2021 17:27
@jparise jparise requested a review from scohen November 26, 2021 17:28
config/dev.exs Outdated Show resolved Hide resolved
This was previously used to manage log output from Erlang :error_logger.
It may have also been a dependency of exometer_core at some point in the
past, but I couldn't find a reference to it after some brief searching.

Either way, :logger itself does the same job without the additional
dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lager is not really used, but it is in dependencies
2 participants