Controlling process #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| |> Enum.map(&(:exometer_report.subscribe(reporter, name, &1, interval))) | ||
| end | ||
| :ets.insert(@elixometer_table, {{:subscriptions, name}, true}) | ||
| def ensure_registered(name, register_fn) do |
There was a problem hiding this comment.
This could use some documentation. It took me a minute to realize what "name" is here and how subscribe(name) (called within) differs from subscribe_to(name).
|
Just some minor comments. Looks good overall! |
In one of our high-throughput systems, timing messages were a bottleneck because the update calls were synchronous. This PR moves the calls to an updater process that is capped at 1000 messages in its queue using the pobox framework. This should alleviate the bottleneck and prevent the process mailboxes from getting too big.
scohen
force-pushed
the
controlling_process
branch
from
c18e1e9 to
5a06b48
Compare
scohen
force-pushed
the
controlling_process
branch
from
5a06b48 to
4fe9234
Compare
annard
pushed a commit
to Intellicore/elixometer
that referenced
this pull request
Oct 11, 2016
* Addressing bottleneck In one of our high-throughput systems, timing messages were a bottleneck because the update calls were synchronous. This PR moves the calls to an updater process that is capped at 1000 messages in its queue using the pobox framework. This should alleviate the bottleneck and prevent the process mailboxes from getting too big. * Addressed PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used in code that's called a lot, Elixometer's main process can become a bottleneck. I witnessed this in our rate limiter, where we would send quite a few performance metrics through Elixometer, which would negatively affect the 99% response time of the app.
The cause of this is Elixometer's synchronous
gen_server, which waits untilexometerresponds before returning. This PR creates anothergen_server, theUpdaterthat does the work of notifying exometer. The updater also uses thepo_boxlibrary to ensure its mailbox doesn't overflow. This means that Elixometer can drop messages, but I think that's a better compromise than having it affect your system's performance.@jparise