Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the histogram truncate option a function argument for update_histogram #56

Merged
merged 3 commits into from
Oct 17, 2016

Conversation

entone
Copy link
Contributor

@entone entone commented Oct 11, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.339% when pulling 2959c0b on NationalAssociationOfRealtors:master into 520e2a2 on pinterest:master.

@jparise
Copy link
Collaborator

jparise commented Oct 12, 2016

@entone, could you also add a test case that uses this new keyword?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.339% when pulling 5952071 on NationalAssociationOfRealtors:master into 520e2a2 on pinterest:master.

@entone
Copy link
Contributor Author

entone commented Oct 13, 2016

Unfortunately had to add a sleep into the test functions, but that's the nature of the beast.

@scohen
Copy link
Collaborator

scohen commented Oct 17, 2016

@entone LGTM.

@scohen scohen merged commit 3ebedb9 into pinterest:master Oct 17, 2016
@entone
Copy link
Contributor Author

entone commented Oct 25, 2016

Should I open a pull request to bump the version to get this pushed to hex?

On Mon, Oct 17, 2016 at 12:07 PM, Steve Cohen [email protected]
wrote:

Merged #56 #56.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#56 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAJmrZaHrjEB3T_-ELzrf9wBLG5hzN5Qks5q06s9gaJpZM4KUF2V
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants