Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a list as a fallback for :subscribe_options #58

Merged
merged 1 commit into from
Oct 30, 2016

Conversation

ctreatma
Copy link
Contributor

The :subscribe_options configuration entry is documented
as a list, but the fallback value is true. This causes
problems with, e.g., the InfluxDB reporter, which expects
extra subscription options to be a list or undefined.

The `:subscribe_options` configuration entry is documented
as a list, but the fallback value is `true`.  This causes
problems with, e.g., the InfluxDB reporter, which expects
extra subscription options to be a list or `undefined`.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.791% when pulling 279ad31 on ctreatma:feature/fix_for_influxdb into 38940d9 on pinterest:master.

@scohen scohen merged commit d9adc56 into pinterest:master Oct 30, 2016
@ctreatma ctreatma deleted the feature/fix_for_influxdb branch November 1, 2017 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants