Broaden support for pre-computing metric names #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profiling showed a significant amount of time being spent in Utils.name_to_exometer and to_atom_list. One solution is to convert static metric names to lists ahead of time, or otherwise manually assembling the desired list form of the metric. Updater.timer supports this pattern by avoiding a double conversion, but counter/etc do not. This change should add support to all metric types. There is a bit of redundancy now in that Updater.timer still does its check. I haven't removed it because I'm not sure if there was some reason we always wanted timer metric names converted in the calling process, rather than in the registered Updater process.
scohen
reviewed
Dec 22, 2016
| @@ -1,4 +1,9 @@ | |||
| defmodule Elixometer.Utils do | |||
| # Name may already have been converted elsewhere. | |||
| def name_to_exometer(_metric_type, name) when is_list(name) do | |||
There was a problem hiding this comment.
careful; someone could define metrics with single quotes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling showed a significant amount of time being spent in
Utils.name_to_exometer and to_atom_list. One solution is to convert static
metric names to lists ahead of time, or otherwise manually assembling the
desired list form of the metric. Updater.timer supports this pattern by
avoiding a double conversion, but counter/etc do not. This change should
add support to all metric types.
There is a bit of redundancy now in that Updater.timer still does its check. I
haven't removed it because I'm not sure if there was some reason we always
wanted timer metric names converted in the calling process, rather than in the
registered Updater process.