Allow :env to be configurable from env variables #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorbash
force-pushed
the
configurable-env
branch
from
f2a56c2 to
645ea63
Compare
scohen
approved these changes
Jun 27, 2017
|
@zorbash, any idea what's going on with those test failures? |
zorbash
force-pushed
the
configurable-env
branch
from
645ea63 to
676ff65
Compare
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
test/elixometer_test.exs
Outdated
| original_env = Application.get_env(:elixometer, :env) | ||
| Application.put_env(:elixometer, :env, {:system, "ELIXOMETER_MISSING_ENV"}) | ||
|
|
||
|
|
There was a problem hiding this comment.
There should be no more than 1 consecutive blank lines.
zorbash
force-pushed
the
configurable-env
branch
from
676ff65 to
4699850
Compare
|
I had to add: to ensure cleanup even when an assertion fails and
|
scohen
reviewed
Jun 27, 2017
test/elixometer_test.exs
Outdated
|
|
||
| assert get_metric_value("elixometer.spirals.precomputed_counter", :one) == {:ok, 123} | ||
|
|
||
| Application.put_env(:elixometer, :env, original_env) |
There was a problem hiding this comment.
Do you need to do this in both the tests and in the on_exit callback?
There was a problem hiding this comment.
Since it's in the on_exit callback it's no longer needed in the tests. Removing ✂️ .
In your config/config.exs you can set {:system, "ENV_VARIABLE"} to allow
the env to be set with environmental variables supplied on runtime.
```
config :elixometer, env: {:system, "ELIXOMETER_ENV"}
```
zorbash
force-pushed
the
configurable-env
branch
from
4699850 to
a6ea1c9
Compare
|
Looks good, @zorbash! Could you also mention this in the |
zorbash
force-pushed
the
configurable-env
branch
from
47814b9 to
973227b
Compare
|
@jparise I added a mention. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In your config/config.exs you can set {:system, "ENV_VARIABLE_HERE"} to allow the
env to be set with environmental variables supplied on runtime.