Refactor user data #1488
Merged
Refactor user data #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The userData is defined as Map<String,String>. It is abused to pass down information to ASTNodes. It makes maintenance brittle as there is no compile time checking on key and values. Also, it may conflict with settings in ".editorconfig", or at least it is ambiguous which takes precedence.
…ditorConfigProperties
…ride.codeStyleProperty
…ault editor config properties. Some of those properties (ktlint_code_style and disabled_rules) are not used in the rules but in the lint/format engine only.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The userData is defined as Map<String,String>. It is abused to pass down information to ASTNodes. It makes maintenance brittle as there is no compile time checking on key and values. Also, it may conflict with settings in ".editorconfig", or at least it is ambiguous which takes precedence.
Replace property
Ktlint.ANDROID_USER_DATA_KEYwith EditorConfigOverride.codeStyleProperty. The boolen property is also change to an enumeration (official, android).Enforce registration of ".editorconfig" properties in interface UsesEditorConfigProperties
Field
ExperimentalParamslogs warnings when still used. It will be removed in a future release.Also generate the '.editorconfig' properties which are defined as default editor config properties. Some of those properties (ktlint_code_style and disabled_rules) are not used in the rules but in the lint/format engine only.
Other minor cleanups
Checklist
CHANGELOG.mdis updatedIn case of adding a new rule:
README.mdis updated