WIP: Support union types #1011
Merged
WIP: Support union types #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Unhandled type uniontype<int,string>
(Expected to fail)
| byte mask = 0; | ||
|
|
||
| mask |= value.isBoolean() ? BOOLEAN_MASK : 0; | ||
| mask |= value.isNumber() ? NUMBER_MASK : 0; |
There was a problem hiding this comment.
Why continuously |=? You can only has one type mask
There was a problem hiding this comment.
Thanks for the quick response. When I started working on this, at the beginning I thought for reason that two of the JSON types could co-exist in a single value. I was probably thinking of a case where a JSON value may be either null or not-null (in a sense that both {"key":"value"} and {"key":null} are valid), which clearly does not apply here. That was me being silly. Perhaps I should replace the whole mask stuff with enum.
suminb
force-pushed
the
feature/union-types
branch
from
a9cb26b to
a832d58
Compare
|
lgtm |
HenryCaiHaiying
added a commit
that referenced
this pull request
Oct 20, 2019
Follow-up of #1011 (Support union types)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #982, I've gained some knowledge on how ORC format works. So I might as well implement
UnionColumnConverterto support union types.This is more like a proposal/brainstorming rather than a complete solution. As marked as
TODOorFIXMEthere are some pending tasks as well. Any feedback and discussions are welcomed.