Add golden dashboards to home page

pinterest · Nov 17, 2024 · e96ac1c · e96ac1c
1 parent 1c1a9cd
commit e96ac1c
Show file tree

Hide file tree

Showing 5 changed files with 62 additions and 17 deletions.
diff --git a/superset-frontend/src/features/home/DashboardTable.tsx b/superset-frontend/src/features/home/DashboardTable.tsx
@@ -50,6 +50,7 @@ function DashboardTable({
   addDangerToast,
   addSuccessToast,
   mine,
+  golden,
   showThumbnails,
   otherTabData,
   otherTabFilters,
@@ -58,7 +59,7 @@ function DashboardTable({
   const history = useHistory();
   const defaultTab = getItem(
     LocalStorageKeys.HomepageDashboardFilter,
-    TableTab.Other,
+    TableTab.Golden,
   );
 
   const filteredOtherTabData = filter(
@@ -77,7 +78,11 @@ function DashboardTable({
     t('dashboard'),
     addDangerToast,
     true,
-    defaultTab === TableTab.Mine ? mine : filteredOtherTabData,
+    defaultTab === TableTab.Mine
+      ? mine
+      : defaultTab === TableTab.Golden
+        ? golden
+        : filteredOtherTabData,
     [],
     false,
   );
@@ -151,6 +156,14 @@ function DashboardTable({
     );
 
   const menuTabs = [
+    {
+      name: TableTab.Golden,
+      label: t('Golden'),
+      onClick: () => {
+        setActiveTab(TableTab.Golden);
+        setItem(LocalStorageKeys.HomepageDashboardFilter, TableTab.Golden);
+      },
+    },
     {
       name: TableTab.Favorite,
       label: t('Favorite'),

diff --git a/superset-frontend/src/features/home/EmptyState.tsx b/superset-frontend/src/features/home/EmptyState.tsx
@@ -127,7 +127,8 @@ export default function EmptyState({
   if (
     tab === TableTab.Mine ||
     tableName === WelcomeTable.Recents ||
-    tab === TableTab.Other
+    tab === TableTab.Other ||
+    tab === TableTab.Golden
   ) {
     return (
       <EmptyContainer>

diff --git a/superset-frontend/src/pages/Home/index.tsx b/superset-frontend/src/pages/Home/index.tsx
@@ -41,6 +41,7 @@ import withToasts from 'src/components/MessageToasts/withToasts';
 import {
   CardContainer,
   createErrorHandler,
+  getGoldenDashboards,
   getRecentActivityObjs,
   getUserOwnedObjects,
   loadingCardCount,
@@ -176,6 +177,8 @@ function Welcome({ user, addDangerToast }: WelcomeProps) {
   const [dashboardData, setDashboardData] = useState<Array<object> | null>(
     null,
   );
+  const [goldenDashboardData, setGoldenDashboardData] =
+    useState<Array<object> | null>(null);
   const [isFetchingActivityData, setIsFetchingActivityData] = useState(true);
 
   const collapseState = getItem(LocalStorageKeys.HomepageCollapseState, []);
@@ -298,6 +301,18 @@ function Welcome({ user, addDangerToast }: WelcomeProps) {
     ]).then(() => {
       setIsFetchingActivityData(false);
     });
+    getGoldenDashboards()
+      .then(r => {
+        setGoldenDashboardData(r);
+        return Promise.resolve();
+      })
+      .catch((err: unknown) => {
+        setGoldenDashboardData([]);
+        addDangerToast(
+          t('There was an issue fetching golden dashboards: %s', err),
+        );
+        return Promise.resolve();
+      });
   }, [otherTabFilters]);
 
   const handleToggle = () => {
@@ -365,6 +380,21 @@ function Welcome({ user, addDangerToast }: WelcomeProps) {
               ghost
               bigger
             >
+              <Collapse.Panel header={t('Dashboards')} key="2">
+                {!dashboardData || isRecentActivityLoading ? (
+                  <LoadingCards cover={checked} />
+                ) : (
+                  <DashboardTable
+                    user={user}
+                    mine={dashboardData}
+                    golden={goldenDashboardData}
+                    showThumbnails={checked}
+                    otherTabData={activityData?.[TableTab.Other]}
+                    otherTabFilters={otherTabFilters}
+                    otherTabTitle={otherTabTitle}
+                  />
+                )}
+              </Collapse.Panel>
               <Collapse.Panel header={t('Recents')} key="1">
                 {activityData &&
                 (activityData[TableTab.Viewed] ||
@@ -382,20 +412,6 @@ function Welcome({ user, addDangerToast }: WelcomeProps) {
                   <LoadingCards />
                 )}
               </Collapse.Panel>
-              <Collapse.Panel header={t('Dashboards')} key="2">
-                {!dashboardData || isRecentActivityLoading ? (
-                  <LoadingCards cover={checked} />
-                ) : (
-                  <DashboardTable
-                    user={user}
-                    mine={dashboardData}
-                    showThumbnails={checked}
-                    otherTabData={activityData?.[TableTab.Other]}
-                    otherTabFilters={otherTabFilters}
-                    otherTabTitle={otherTabTitle}
-                  />
-                )}
-              </Collapse.Panel>
               <Collapse.Panel header={t('Charts')} key="3">
                 {!chartData || isRecentActivityLoading ? (
                   <LoadingCards cover={checked} />

diff --git a/superset-frontend/src/views/CRUD/types.ts b/superset-frontend/src/views/CRUD/types.ts
@@ -32,6 +32,7 @@ export enum TableTab {
   Viewed = 'Viewed',
   Created = 'Created',
   Edited = 'Edited',
+  Golden = 'Golden',
 }
 
 export type Filter = {
@@ -45,6 +46,7 @@ export interface DashboardTableProps {
   addSuccessToast: (message: string) => void;
   user?: User;
   mine: Array<Dashboard>;
+  golden: Array<Dashboard>;
   showThumbnails?: boolean;
   otherTabData: Array<Dashboard>;
   otherTabFilters: Filter[];

diff --git a/superset-frontend/src/views/CRUD/utils.tsx b/superset-frontend/src/views/CRUD/utils.tsx
@@ -167,6 +167,19 @@ export const getEditedObjects = (userId: string | number) => {
     .catch(err => err);
 };
 
+export const getGoldenDashboards = (
+  filters: Filter[] = [
+    {
+      col: 'tags',
+      opr: 'dashboard_tags',
+      value: 'Golden',
+    },
+  ],
+) =>
+  SupersetClient.get({
+    endpoint: `/api/v1/dashboard/?q=${getParams(filters)}`,
+  }).then(res => res.json?.result);
+
 export const getUserOwnedObjects = (
   userId: string | number,
   resource: string,