Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DASHBOARD_RBAC): Update dashboard RBAC to require permission to add/update dashboard roles #40

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

kgopal492
Copy link

@kgopal492 kgopal492 commented Dec 24, 2024

SUMMARY

  • Create/Edit dashboard requires that user has can_edit "PinterestDashboardRoles" permission before allowing creating/updating dashboard roles for RBAC

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (pinterest-release-4.0.2@1c1a9cd). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             pinterest-release-4.0.2      #40   +/-   ##
==========================================================
  Coverage                           ?   83.06%           
==========================================================
  Files                              ?      513           
  Lines                              ?    36144           
  Branches                           ?        0           
==========================================================
  Hits                               ?    30024           
  Misses                             ?     6120           
  Partials                           ?        0           
Flag Coverage Δ
hive 48.87% <10.00%> (?)
mysql 77.88% <100.00%> (?)
postgres 78.00% <100.00%> (?)
presto 53.61% <10.00%> (?)
python 83.06% <100.00%> (?)
sqlite 77.45% <100.00%> (?)
unit 56.65% <10.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kgopal492 kgopal492 merged commit b69cc7e into pinterest:pinterest-release-4.0.2 Jan 7, 2025
19 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants