Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alerts): Make sure null values aren't considered to be equal to 0 #46

Merged

Conversation

kgopal492
Copy link

SUMMARY

Previously, the alert logic converted NULL results to 0.0 for comparison. However this incorrectly resulted in alerts triggered when the result is null if the alert is testing equality to 0. This logic uses np.nan to compare alerts with values.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (pinterest-release-4.1.1@bfc4be1). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             pinterest-release-4.1.1      #46   +/-   ##
==========================================================
  Coverage                           ?   83.62%           
==========================================================
  Files                              ?      535           
  Lines                              ?    38538           
  Branches                           ?        0           
==========================================================
  Hits                               ?    32226           
  Misses                             ?     6312           
  Partials                           ?        0           
Flag Coverage Δ
hive 48.92% <0.00%> (?)
postgres 76.86% <100.00%> (?)
presto 53.43% <0.00%> (?)
python 83.62% <100.00%> (?)
sqlite 76.33% <100.00%> (?)
unit 60.25% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kgopal492 kgopal492 merged commit e4f1691 into pinterest:pinterest-release-4.1.1 Feb 18, 2025
18 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants