Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NewCNAMESourceDescription helper method #111

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

kevmo314
Copy link
Contributor

Description

This specific source description is very common. This change introduces
a helper method to simplify the creation of CNAME source descriptions.

Reference issue

One part of #22

This specific source description is very common. This change introduces
a helper method to simplify the creation of CNAME source descriptions.

#22
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #111 (9495669) into master (a4508c4) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   72.45%   72.62%   +0.17%     
==========================================
  Files          20       20              
  Lines        1285     1293       +8     
==========================================
+ Hits          931      939       +8     
  Misses        268      268              
  Partials       86       86              
Flag Coverage Δ
go 72.62% <100.00%> (+0.17%) ⬆️
wasm 72.62% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source_description.go 78.44% <100.00%> (+1.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4508c4...9495669. Read the comment docs.

@kevmo314 kevmo314 merged commit 2a0c93d into master Nov 19, 2021
@kevmo314 kevmo314 deleted the cname-packets branch November 19, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants