Update code to be more Go idiomatic

No functional changes
pion · Nov 1, 2022 · 789623a · 789623a
1 parent c132bed
commit 789623a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/AUTHORS.txt b/AUTHORS.txt
@@ -117,6 +117,7 @@ Michiel De Backker <[email protected]>
 Mike Coleman <[email protected]>
 Mindgamesnl <[email protected]>
 mission-liao <[email protected]>
+mr-shitij <[email protected]>
 mxmCherry <[email protected]>
 Nam V. Do <[email protected]>
 Nick Mykins <[email protected]>

diff --git a/icegatherer_test.go b/icegatherer_test.go
@@ -53,8 +53,8 @@ func TestNewICEGatherer_Success(t *testing.T) {
 		t.Error(err)
 	}
 
-	if len(params.UsernameFragment) == 0 ||
-		len(params.Password) == 0 {
+	if params.UsernameFragment == "" ||
+		params.Password == "" {
 		t.Fatalf("Empty local username or password frag")
 	}
 

diff --git a/pkg/media/h264reader/h264reader.go b/pkg/media/h264reader/h264reader.go
@@ -145,9 +145,8 @@ func (reader *H264Reader) NextNAL() (*NAL, error) {
 			if nal.UnitType == NalUnitTypeSEI {
 				reader.nalBuffer = nil
 				continue
-			} else {
-				break
 			}
+			break
 		}
 
 		reader.nalBuffer = append(reader.nalBuffer, readByte)