Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestPeerConnection_EventHandlers flaky on WASM #2848

Closed
edaniels opened this issue Aug 2, 2024 · 0 comments · Fixed by #2849
Closed

TestPeerConnection_EventHandlers flaky on WASM #2848

edaniels opened this issue Aug 2, 2024 · 0 comments · Fixed by #2849

Comments

@edaniels
Copy link
Member

edaniels commented Aug 2, 2024 

--- FAIL: TestPeerConnection_EventHandlers (0.14s)
    peerconnection_test.go:392: State in callback argument is different from ConnectionState(): callbackState=connecting, storedState=connected

Want to try it locally?

yarn
GOOS=js GOARCH=wasm go test -exec ./test-wasm/go_js_wasm_exec  -run TestPeerConnection_EventHandlers -count=1000 -failfast
@edaniels edaniels mentioned this issue Aug 2, 2024
Merged
edaniels added a commit to edaniels/webrtc that referenced this issue Aug 2, 2024
@edaniels
Fix TestPeerConnection_EventHandlers flake
5ed2676 
- Fixes pion#2848
@edaniels edaniels mentioned this issue Aug 2, 2024
Merged
edaniels added a commit to edaniels/webrtc that referenced this issue Aug 2, 2024
@edaniels
Fix TestPeerConnection_EventHandlers flake
515be46 
- Fixes pion#2848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TestPeerConnection_EventHandlers flake edaniels/webrtc
1 participant
@edaniels