Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PeerConnection.GracefulClose #2847

Merged
merged 1 commit into from
Aug 6, 2024

Add PeerConnection.GracefulClose

93ac274
Select commit
Loading
Failed to load commit list.
Merged

Add PeerConnection.GracefulClose #2847

Add PeerConnection.GracefulClose
93ac274
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 6, 2024 in 0s

65.11% (-13.84%) compared to dbe26d3

View this Pull Request on Codecov

65.11% (-13.84%) compared to dbe26d3

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.11%. Comparing base (dbe26d3) to head (93ac274).

Files Patch % Lines
operations.go 80.00% 5 Missing and 1 partial ⚠️
internal/mux/mux.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (dbe26d3) and HEAD (93ac274). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (dbe26d3) HEAD (93ac274)
go 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2847       +/-   ##
===========================================
- Coverage   78.94%   65.11%   -13.84%     
===========================================
  Files          89       67       -22     
  Lines        8335     3262     -5073     
===========================================
- Hits         6580     2124     -4456     
+ Misses       1278     1011      -267     
+ Partials      477      127      -350     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.