macosx packaging #1018 #1019
Closed
macosx packaging #1018 #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,9 +3,9 @@ AROPT = crs | |||
| DLSUFFIX = .so | |||
|
|
|||
| ifdef PGXS | |||
| BE_DLLLIBS = -bundle_loader $(bindir)/postgres | |||
| BE_DLLLIBS = -bundle_loader $(bindir)/pipeline-server | |||
There was a problem hiding this comment.
We've also changed a few binary names like pg_config -> pipeline-config. Is there any darwin specific stuff for them too?
There was a problem hiding this comment.
Didn't see any build errors, and a quick grep doesn't show any other BE_DLLLIBS that looks wrong. Not sure what that flag does tbh. Some mac voodoo.
There was a problem hiding this comment.
Makefiles are a black art imo.
There was a problem hiding this comment.
something to do with the linker: pgRouting/pgrouting#5
|
Looks solid dude! |
|
I'm going to merge this in with the packaging branch I've been working on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds, installs and runs on Mavericks 10.9.5
Still need testing on Yosemite.