Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models/tfidfmodel.py variablename idfs should be dfs #2

Closed
Dieterbe opened this issue Feb 16, 2011 · 1 comment
Closed

models/tfidfmodel.py variablename idfs should be dfs #2

Dieterbe opened this issue Feb 16, 2011 · 1 comment

Comments

@Dieterbe
Copy link
Contributor

src/gensim/models/tfidfmodel.py

in the initialize method:
idfs = {}
(...)
for termId, termCount in bow:
idfs[termId] = idfs.get(termId, 0) + 1

shouldn't this variable called "dfs" or something? because they are just document frequencies which are not yet inversed.

@piskvorky
Copy link
Owner

you're right, i'll rename it :)

piskvorky pushed a commit that referenced this issue Jun 6, 2014
piskvorky pushed a commit that referenced this issue Sep 14, 2014
piskvorky pushed a commit that referenced this issue Oct 5, 2014
@lerela lerela mentioned this issue Oct 16, 2014
piskvorky pushed a commit that referenced this issue Apr 5, 2015
Fixed ShardedCorpus & tests for Python 3.
tmylk pushed a commit that referenced this issue Sep 30, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants