inline logsumexp() #1744
Closed
inline logsumexp() #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 28, 2017 21:54
logsumexp accounts for 50% of the run time of ldamodel. Much of this time is spent by "robustness" checks performed by scipy's logsumexp (eg, _asarray_validated, checks for NaNs, etc.). Removing these checks greatly improves the overall performance of ldamodel. Eg, run time when fitting a lda model on the endron dataset (from UCI) decreases from 20-40%.
logsumexp accounts for 50% of the run time of ldamodel. Much of this time is spent by "robustness" checks performed by scipy's logsumexp (eg, _asarray_validated, checks for NaNs, etc.). Removing these checks greatly improves the overall performance of ldamodel. Eg, run time when fitting a lda model on the enron dataset (from UCI) decreases from 20-40%.
… performance-logsumexp
|
Oh, wow! That's interesting -- why is this closed? |
|
@piskvorky this is re-created as #1745 |
|
Ah, ok. Thanks. Please cross-link such PRs, otherwise it's not obvious to people what's happening (including myself). |
|
apologies, still getting the hang of the github interface and created this pull request prematurely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scipy's logsumexp performs some robustness checks that are likely not necessary for ldamodel. Inlining a barebones version of logsumexp speeds up ldamodel by 20-40%