Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test initialisation issue for test_wikicorpus.py, fix#956 #957

Merged
merged 1 commit into from
Oct 18, 2016

Conversation

markroxor
Copy link
Contributor

@markroxor markroxor commented Oct 17, 2016

Initialising unittest for TestWikiCorpus ,fix #956

@markroxor
Copy link
Contributor Author

markroxor commented Oct 17, 2016

Both(python 2.7.9 and python 3.4.2) builds pass on my VM and my Travis.

@tmylk
Copy link
Contributor

tmylk commented Oct 18, 2016

2.7 test still hangs in the same way. Are you sure that this is the solution?

@markroxor
Copy link
Contributor Author

It works fine on my VM and Travis. I can't imitate the error.

@tmylk
Copy link
Contributor

tmylk commented Oct 18, 2016

did it work fine before this change too?

@markroxor
Copy link
Contributor Author

markroxor commented Oct 18, 2016

It worked fine but did not throw any message (whether the test was ok or not)

@tmylk
Copy link
Contributor

tmylk commented Oct 18, 2016

how did you run it? so what is the reason for this change?

@markroxor
Copy link
Contributor Author

I followed .travis.yml on my VM.
All the other test_xx.py files include
if __name__ == '__main__':
logging.basicConfig(format='%(asctime)s : %(levelname)s : %(message)s', level=logging.DEBUG)
unittest.main()
so that the testxxx methods are invoked. Also according to the documentation.

@tmylk tmylk merged commit bd296ea into piskvorky:develop Oct 18, 2016
@tmylk
Copy link
Contributor

tmylk commented Oct 18, 2016

Sure, thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix unit test initialisation issue for test_wikicorpus.py
2 participants