#8206: Handle target=_blank links in MS Edge sidePanel sub-frames

[fregante]

What does this PR do?

• Part of MS Edge: clicking a link in a sidebar mod crashes MS Edge #8206

Discussion

#7889 added a click listener to the links in Edge in order to intercept and manually open a new popup.

Iframes are not covered by this listener, so each iframe needs its own listener.

In this PR I used the content script to add the listener, because presumably these frames natively receive the content script.

Demo

Untested

Checklist

• Add jest or playwright tests and/or storybook stories
• Designate a primary reviewer: @fungairino

[fregante]

Side note: this doesn't cover frames that use a base tag to have a default target. If necessary, it can be done in a followup PR (easy fix in openAllLinksInPopups:

link.target === "_blank" || document.querySelector('base[target="_blank"]')

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 73.43%. Comparing base (6d95047) to head (71e91bf).
Report is 31 commits behind head on main.

Files	Patch %	Lines
src/utils/openAllLinksInPopups.ts	0.00%	12 Missing ⚠️
src/contentScript/contentScript.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8223      +/-   ##
==========================================
- Coverage   73.47%   73.43%   -0.05%     
==========================================
  Files        1334     1351      +17     
  Lines       41259    41373     +114     
  Branches     7686     7715      +29     
==========================================
+ Hits        30316    30383      +67     
- Misses      10943    10990      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[twschiller]

Things to double-check:

• Does this work only with links on the screen on initial page load? Or all links?
• Coordinate with @mthek10 to test in the AA Copilot iframe

[fregante]

• It should cover all links, it's a single global listener

[fungairino]

Looks good to me, but I'd recommend manually verifying this change before merging. (PR notes these changes are untested)

[twschiller]

Looks good to me, but I'd recommend manually verifying this change before merging

@grahamlangford @fungairino you'll need to coordinate on testing

[github-actions]

Playwright test results - MV2

 38 passed
 2 flaky
 8 skipped

Details

 Open report ↗︎
 48 tests across 17 suites
 10 minutes, 6 seconds
 71e91bf

Flaky tests

chromeSetup › auth.setup.ts › authenticate
edge › tests/extensionConsoleActivation.spec.ts › can activate a mod with a database

Skipped tests

chrome › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration
edge › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration
chrome › tests/runtime/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
edge › tests/runtime/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
chrome › tests/runtime/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
chrome › tests/runtime/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation
edge › tests/runtime/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
edge › tests/runtime/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation

[github-actions]

Playwright test results - MV3

 48 passed

Details

 Open report ↗︎
 48 tests across 17 suites
 12 minutes, 59 seconds
 71e91bf