Allow an emitter to automatically update via the PIXI shared ticker #38
+39
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewstart
requested changes
Jan 13, 2017
| @@ -745,12 +756,39 @@ | |||
| }); | |||
|
|
|||
| /** | |||
| * If particles should be emitted during update() calls. Setting this to false | |||
| * stops new particles from being created, but allows existing ones to die out. | |||
| * @property {Boolean} emit | |||
There was a problem hiding this comment.
This appears to be the docs for emit.
| { | ||
| ticker.remove(this.update, this); | ||
| } | ||
| else if (!this._autoUpdate && value === true) |
There was a problem hiding this comment.
Given that you are converting to a boolean value when setting _autoUpdate at the bottom of this, it seems odd to use strict equality rather than just using value as falsy and truthy.
| * Updates all particles spawned by this emitter and emits new ones. | ||
| * @method update | ||
| * @param {Number} delta Time elapsed since the previous frame, in __seconds__. | ||
| */ | ||
| p.update = function(delta) | ||
| { | ||
| if (this._autoUpdate) | ||
| { | ||
| delta *= 0.01; |
There was a problem hiding this comment.
In pixi-animate I set up some code to convert from ticker delta (which is not hundredths of a second) to actual elapsed seconds. Would that be worth reusing here?
* Corrected docs * value to be truthy falsy rather than strictly checked * delta to use more accurate code from pixi-animate
|
Done. Sorry about the tardiness of the PR, esp the copy paste documentation fail. |
andrewstart
reviewed
Jan 13, 2017
| @@ -745,12 +756,39 @@ | |||
| }); | |||
|
|
|||
| /** | |||
| * If the update function is called automatically from the shared ticker. | |||
| * Setting this to false requires calling the update function manually. | |||
| * @property {Boolean} emit | |||
There was a problem hiding this comment.
Please also change "emit" to "autoUpdate" here.
andrewstart
approved these changes
Jan 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.