Use new Function() instead of eval() #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using pixi-particles with Rollup.js, it will throw an error if you use eval() directly. See https://github.com/rollup/rollup/wiki/Troubleshooting#avoiding-eval
This should be effectively identical to the
eval
call, except for the possibility ofeval
grabbing or writing to local variables (a trait that the original code actually relied on). This also feels marginally cleaner, though it's only fractionally more secure.Tested to verify that it still works as expected.