Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Errors resulting from identical TPS file names in different dir #111

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

h1ve2
Copy link
Contributor

@h1ve2 h1ve2 commented Jan 24, 2025

TPS Compatible with files with the same name in different directories.

@h1ve2 h1ve2 changed the title Fix: Errors resulting from identical TPS file names in different dir fix: Errors resulting from identical TPS file names in different dir Jan 24, 2025
@Zyie
Copy link
Member

Zyie commented Jan 24, 2025

hey @h1ve2 can you provide me a screenshot of your directory or a replica using a tool like this

It would be helpful for me to get an understanding of how this issue forms

@h1ve2
Copy link
Contributor Author

h1ve2 commented Jan 24, 2025

hey @h1ve2 can you provide me a screenshot of your directory or a replica using a tool like this

It would be helpful for me to get an understanding of how this issue forms

@Zyie here are my screenshots

raw-assets ↓
59935fb4905387a0dea44fe5f766757

old result ↓
image

texturePackerCacheBuster did not handle image names correctly
all I do is determine whether an image and a json directory are the same.

now it's working as expected. ↓
image

Copy link
Member

@Zyie Zyie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Feb 5, 2025
@Zyie Zyie added this pull request to the merge queue Feb 5, 2025
Merged via the queue into pixijs:main with commit d936c10 Feb 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants