Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add strict mode #121

Merged
merged 10 commits into from
Feb 6, 2025
Merged

feat: add strict mode #121

merged 10 commits into from
Feb 6, 2025

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented Feb 6, 2025

Adds a strict mode to Assetpack where any Logger.error causes assetpack to fail and the process to exit

GoodBoyDigital
GoodBoyDigital approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! may be we rename logger to somthing else now it also is responsible for throwing errors?

Base automatically changed from feat/nomip-tag to main February 6, 2025 11:15
@Zyie Zyie added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 2bf1e06 Feb 6, 2025
7 checks passed
@Zyie Zyie deleted the feat/strict branch February 6, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GoodBoyDigital GoodBoyDigital GoodBoyDigital approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zyie @GoodBoyDigital