Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-parent on render group issue #11041

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: re-parent on render group issue #11041

merged 1 commit into from
Nov 8, 2024

Conversation

GoodBoyDigital
Copy link
Member

Description of change

Fixes an issue where adding a child to its existing parent that has render group enabled will not cause the scene to rebuild.
Added a test to cover this situation too.

fixes #11039

Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR title doesn't match the required format. The title should be in this format:

chore: update Text docs
fix: text not rendering
feat: add new feature to Text
breaking: remove Text#resolution 

Copy link

codesandbox-ci bot commented Nov 8, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 03a5d14:

Sandbox Source
pixi.js-sandbox Configuration

Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@GoodBoyDigital GoodBoyDigital changed the title fix re-parent on render group issue fix: re-parent on render group issue Nov 8, 2024
@GoodBoyDigital GoodBoyDigital added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Nov 8, 2024
@Zyie Zyie added this pull request to the merge queue Nov 8, 2024
Merged via the queue into dev with commit f03c9fc Nov 8, 2024
6 of 7 checks passed
@Zyie Zyie deleted the bug/reparant-container branch November 8, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Objects do not stand out on stage when touched
3 participants