Deprecate PJ_ENABLE_EXTRA_CHECK macro #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauwming
reviewed
Mar 7, 2022
| */ | ||
| #if defined(PJ_ENABLE_EXTRA_CHECK) && PJ_ENABLE_EXTRA_CHECK != 0 |
There was a problem hiding this comment.
For deprecation, we normally comment it first instead of directly removing it.
/* PJ_ENABLE EXTRA_CHECK is deprecated in PJSIP 2.13. */
// #if defined(PJ_ENABLE_EXTRA_CHECK) && PJ_ENABLE_EXTRA_CHECK != 0
pjlib/include/pj/config.h
Outdated
| * | ||
| * PJ_ENABLE_EXTRA_CHECK has been deprecated in 2.13. | ||
| */ | ||
| #if defined(PJ_ENABLE_EXTRA_CHECK) |
There was a problem hiding this comment.
If user explicitly enable it, I think we don't need to give any warning to minimise any inconvenience (user may need to remove the setting and rebuild the entire library). The behavior doesn't change anyway.
So we should only give warning if PJ_ENABLE_EXTRA_CHECK==0.
sauwming
approved these changes
Mar 7, 2022
nanangizz
approved these changes
Mar 7, 2022
warting
pushed a commit
to warting/pjproject
that referenced
this pull request
Mar 8, 2022
* Deprecate PJ_ENABLE_EXTRA_CHECK macro * Modification based on comments
arunmitel
pushed a commit
to mitel-networks/pjproject
that referenced
this pull request
Aug 17, 2022
* Deprecate PJ_ENABLE_EXTRA_CHECK macro * Modification based on comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket will deprecate
PJ_ENABLE_EXTRA_CHECKmacro. Initially, it is intended to reduce size on assertion checks.