TLS uses remote IP address instead of hostname when sending BYE #3310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix issue #2706.
The issue seems to occur only when the transport used in dialog creation is a server socket, where remote address is an IP address not a hostname, so the
dlg->initial_dest
will be an IP address. Note that thedlg->initial_dest
is currently used only for initializingtdata->dest_info.name
which eventually used for verifying remote TLS certificate.The idea here is to only set the
dlg->initial_dest
from transport info when the transport is a client socket, which TLS verification is usually performed. When it is a server socket, thetdata->dest_info.name
will be initialized from request URI or route header (later bypjsip_endpt_send_request_stateless()
orpjsip_endpt_send_response()
.