Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS uses remote IP address instead of hostname when sending BYE #3310

Merged
merged 3 commits into from
Jan 21, 2023

Conversation

nanangizz
Copy link
Member

This is an attempt to fix issue #2706.

The issue seems to occur only when the transport used in dialog creation is a server socket, where remote address is an IP address not a hostname, so the dlg->initial_dest will be an IP address. Note that the dlg->initial_dest is currently used only for initializing tdata->dest_info.name which eventually used for verifying remote TLS certificate.

The idea here is to only set the dlg->initial_dest from transport info when the transport is a client socket, which TLS verification is usually performed. When it is a server socket, the tdata->dest_info.name will be initialized from request URI or route header (later by pjsip_endpt_send_request_stateless() or pjsip_endpt_send_response().

@nanangizz nanangizz merged commit 58bfd3d into master Jan 21, 2023
@nanangizz nanangizz deleted the fix2706 branch January 21, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants