Prevent data race in stream when sending RTCP #3528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #1973, copy pasted here for convenience:
"
Reported that race condition scenarios potentially occur in
pjmedia_stream
specifically in call hangup where UI/SIP thread invokespjmedia_stream_destroy()
and media/audio thread that may still doing some streaming processing, both may access the samepjmedia_stream
states without mutex protection. For example,pjmedia_rtcp_build_rtcp_sdes()
may be called at the same time:UI/SIP thread:
Media endpoint thread:
"