Add Metal renderer for Mac and iOS #3841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI is currently failing with "Illegal instruction: 4". It looks like the CI machine doesn't support the Metal API. Let me double check this. |
|
Fixed it in the latest commit:
|
nanangizz
approved these changes
Jan 26, 2024
trengginas
approved these changes
Jan 29, 2024
|
@sauwming I can't see these changes in the latest library version. Why? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current OpenGL ES renderer has been deprecated for iOS since iOS 12.0
(https://developer.apple.com/documentation/opengles).
Thus we need to migrate to the new Metal API. The advantage of the new API is that it's also available for Mac OS (we use APIs that's supported for 10.14+ (https://developer.apple.com/documentation/metal/using_metal_to_draw_a_view_s_contents?language=objc)). This makes SDL no longer required for Mac and we can use the native Metal renderer instead.