Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand tab to spaces and and cleanup formatting #4154

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

aol-nnov
Copy link
Contributor

This is a followup for #3292 and #3210 but regarding aconfigure.ac

@aol-nnov
Copy link
Contributor Author

@sauwming I had a hard time modifying aconfigure.ac during my previous PRs, so I decided to remove mixed indentation in aconfigure.ac first and clean up the formatting. Let's review this and I'll redo my PR on top.

aol-nnov added a commit to aol-nnov/pjproject that referenced this pull request Nov 13, 2024
@sauwming sauwming added this to the release-2.15 milestone Nov 13, 2024
@jimying
Copy link
Contributor

jimying commented Nov 13, 2024

I think it should't format aconfigure which is generated by autoconf tool

@aol-nnov
Copy link
Contributor Author

@jimying aconfigure was re-generated with autoconf. @sauwming told me to do so in other PRs where there are changes in aconfigure.ac, so, I did it in this PR, too.

@aol-nnov
Copy link
Contributor Author

@sauwming is CI failing due to some enviromental issues?

I'm not convinced, that formatting led to

07:54:49.159   waiting for active NS to expire (20 sec)
07:55:09.282   failing server0

@jimying
Copy link
Contributor

jimying commented Nov 13, 2024

@jimying aconfigure was re-generated with autoconf. @sauwming told me to do so in other PRs where there are changes in aconfigure.ac, so, I did it in this PR, too.

ok, i advise use autoconf 2.71 to generate aconfigure to make less changes (Keep use the same autoconf version as before)

@aol-nnov
Copy link
Contributor Author

@jimying unfortunately, autoconf 2.71 is not available in Debian 12 (current stable version of OS)

@jimying
Copy link
Contributor

jimying commented Nov 13, 2024

@jimying unfortunately, autoconf 2.71 is not available in Debian 12 (current stable version of OS)

@aol-nnov I have a debian 12 server, i check that it's autoconf version is 2.71, maybe you need run apt update

@aol-nnov
Copy link
Contributor Author

@jimying sorry for inconvenience, it's Debian 11 here. We still need to build pjsp for that version of OS. If you insist, I'll regenerate with 2.71

@aol-nnov
Copy link
Contributor Author

regenerated with autoconf 2.71

@sauwming sauwming merged commit a1d416a into pjsip:master Nov 13, 2024
36 checks passed
@aol-nnov aol-nnov deleted the fix-indentation branch November 14, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants