Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared CoC and contribution guidelines, fix license in package.json #7

Closed
wants to merge 2 commits into from
Closed

Use shared CoC and contribution guidelines, fix license in package.json #7

wants to merge 2 commits into from

Conversation

dominykas
Copy link
Member

@@ -5,7 +5,7 @@
"main": "index.js",
"type": "commonjs",
"author": "Wes Todd <[email protected]>",
"license": "ISC",
"license": "MIT",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesleytodd I assume the LICENSE file is correct here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I changed the license when I moved it but forgot this! Thanks!

@wesleytodd
Copy link
Member

Some of these files are actually present in the .github directory. I have been doing this because I get annoyed with 20 meta files at the root of my projects, and catching most of them with one .npmignore is nice. I actually think we should look at using a .github repo for this. That way we dont need to PR them all across all the repos.

That said, the package.json change for sure was part I missed when moving it here from my personal repo.

@dominykas
Copy link
Member Author

We might also be able to get away with a .github repo and leave them out in the individual repos, as has been suggested in the issue. I think it's probably best to discuss that over there.

@dominykas
Copy link
Member Author

Updated this to rely on the CoC/contrib docs from the shared .github repo.

@dominykas dominykas changed the title Add CoC and contribution guidelines Use shared CoC and contribution guidelines, fix license in package.json May 13, 2020
@dominykas
Copy link
Member Author

Will open a new PR, based on latest guidelines.

@dominykas dominykas closed this Jul 15, 2020
@dominykas dominykas deleted the housekeeping branch July 15, 2020 21:02
@dominykas dominykas mentioned this pull request Jul 30, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants