Add an option to select another mirror #4
Conversation
| @@ -18,7 +18,7 @@ suite('nv', () => { | |||
| assert.strictEqual(versions[0].versionName, 'v10') | |||
| assert.strictEqual(versions[0].start.toISOString(), '2018-04-24T00:00:00.000Z') | |||
| assert.strictEqual(versions[0].lts.toISOString(), '2018-10-30T00:00:00.000Z') | |||
| assert.strictEqual(versions[0].maintenance.toISOString(), '2020-04-01T00:00:00.000Z') | |||
| assert.strictEqual(versions[0].maintenance.toISOString(), '2020-05-19T00:00:00.000Z') | |||
There was a problem hiding this comment.
This change was necessary to make the tests pass. Didn't investigate further since it's unrelated.
There was a problem hiding this comment.
Interesting, since this test technically tests the upstream json it is probably they changed it. Now that you have this feature though, we could totally setup a mock mirror and point to it for the tests!
There was a problem hiding this comment.
Ah, didn't see this PR earlier - this was extended in nodejs/Release@9bc5275
| @@ -18,7 +18,7 @@ suite('nv', () => { | |||
| assert.strictEqual(versions[0].versionName, 'v10') | |||
| assert.strictEqual(versions[0].start.toISOString(), '2018-04-24T00:00:00.000Z') | |||
| assert.strictEqual(versions[0].lts.toISOString(), '2018-10-30T00:00:00.000Z') | |||
| assert.strictEqual(versions[0].maintenance.toISOString(), '2020-04-01T00:00:00.000Z') | |||
| assert.strictEqual(versions[0].maintenance.toISOString(), '2020-05-19T00:00:00.000Z') | |||
There was a problem hiding this comment.
Interesting, since this test technically tests the upstream json it is probably they changed it. Now that you have this feature though, we could totally setup a mock mirror and point to it for the tests!
|
@wesleytodd this should probably get merged at this point? |
This PR investigates adding a
mirroroption, plus a test usingv8-canary, an Experimental Node.js mirror on V8 lkgr. Mostly a suggestion since I don't know if you are open to changes like this, but was easy to do so I thought I make a PR right away.In my particular use case I'd like to obtain the latest
v8-canarybuild for WebAssembly testing, and having a proper way to do so instead of using some sort of workaround would be great :)