Remove llvm.org as deno dependency on darwin+x86-64 #5765
Conversation
|
rebuilding 1.42.1 to hopefully allow this to pass. |
|
once this is live, i'll rebuild the deno versions since the libunwind change. |
|
I wonder if I should remove the otool test by the way. It does not seem to be proving anything anymore. |
|
I also wonder if I should remove llvm.org as build dependency on darwin+x86-64 now, lol. But I guess tests will let us know. Probably yes. |
|
if we can, we should. |
Removed the tests. The good news is that the current tests are enough to test the libunwind issue: https://github.com/pkgxdev/pantry/actions/runs/8513890027/job/23318505536?pr=5765#step:9:119 |
| # deno does not need llvm to build on darwin+x86-64, and if it is present, | ||
| # deno will be linked to its libunwind, which then causes deno to need llvm | ||
| # in runtime. | ||
| - | | ||
| if test "{{hw.platform}}+{{ hw.arch }}" != "darwin+x86-64"; then | ||
| set -o allexport | ||
| source <(pkgx +llvm.org^17) | ||
| set +o allexport | ||
| fi | ||
|
|
There was a problem hiding this comment.
so, shouldn't this be a build depedency?
build:
dependency:
linux:
llvm.org: ^17
darwin/aarch64:
llvm.org: ^17
?
There was a problem hiding this comment.
For some weird reason it doesn't work:
For some reason when adding rust later, llvm also needs to be added later.
Originally posted by @felipecrs in #5751 (comment)
There was a problem hiding this comment.
But let's try once again: bcd5ec3
There was a problem hiding this comment.
Yeah:
configure: error: no acceptable ld found in $PATH
https://github.com/pkgxdev/pantry/actions/runs/8515078419/job/23321905009?pr=5765#step:6:1399
|
@jhheider sorry to ask but is there anything pending for this to be executed? I'm asking because I'm waiting for it before converting one of my projects to use pkgx to install deno. |
|
sorry, been tied up in other tasks. is the order of operations:
|
|
I think the current version of deno being used by brewkit actions is deno 1.42.1 (#5765 (comment)), so:
|
|
probably need to build ~1.39 as used by pkgx.sh as well; no worries, that's easy. well, let's roll the dice. no time like the present to try and break it to fix it! :) |
|
https://github.com/pkgxdev/pantry/actions/runs/8544318017/job/23410096465 what we need to do is force it to use an old |
|
reverting. |
This does not seem to be using 8e3d31f for some reason:
|
|
yeah... missed pkg-platform.yml; i'll revert the reversion with that change. |
|
Ops, I guess I forgot it. My bad. |
|
no apologies necessary. it's a complex bit of revlock, and your hard work is completely appreciated. |
|
By the way it's probably not necessary to rebuild ~1.39 at first, as I believe pkgx is always used from the precompiled binaries anyway. |
|
well, i think we've got it. 1.42.1 built, rolled out the brewkit diversions, and it built again. building 1.42.0 with it, then i'll trigger all the other rebuilds to go while we all sleep. |
and once this is done, we should be set here.
thanks for all this work, @felipecrs . software's anything but trivial. |
|
Awesome! |
Continues #5751