This repository was archived by the owner on Sep 11, 2022. It is now read-only.
Use of weak self to avoid strongly captured over-retained self in blocks #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkluz
pushed a commit
that referenced
this pull request
Dec 30, 2013
Use of weak self to avoid strongly captured over-retained self in blocks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using your great lib in a project, we ran into a scenario where we had multiple storyboards - one for login, and then one for the main project. The main project had a PKRevealController as it's root VC. If we tore down the VC stack by replacing the window's rootViewController, the PKRevealController's entire hierarchy was retained. After much digging, we found out it was due to the strongly captured self in the animation blocks occurring.