pkp/pkp-lib#9487 Skipped non-conforming setting tables from failing the migration #4096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmecher
requested changes
Nov 29, 2023
There was a problem hiding this comment.
This will work for cases like rt_settings where there is no setting_type column, but other cases where the result columns are not as expected will not work. What do you think about adding an explicit list of necessary columns that are used in the _toJSON function, and checking them against the table's column list? Alternately, it would be OK IMO to specifically exclude the rt_settings table, as that's a known pitfall for users with old databases.
jonasraoni
force-pushed
the
bugfix/stable-3_3_0/9487-fix-migration-exception
branch
from
0d22700 to
3645c40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.