#9535 Skipped submission files that have an invalid file stage at the…

… Native XML plugin
pkp · Nov 27, 2023 · 782e7b1 · 782e7b1
1 parent 0e93d24
commit 782e7b1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/locale/en_US/manager.po b/locale/en_US/manager.po
@@ -1664,6 +1664,9 @@ msgstr "The submission file {$id} was skipped because it is attached to a record
 msgid "plugins.importexport.native.error.submissionFileWithoutRevision"
 msgstr "The submission file {$id} was skipped because it does not have a valid revision."
 
+msgid "plugins.importexport.native.error.submissionFileInvalidFileStage"
+msgstr "The submission file {$id} was skipped because it does not have a valid file stage."
+
 msgid "plugins.importexport.native.error.submissionFileRevisionMissing"
 msgstr "The revision {$revision} of the submission file {$id} was skipped because the file was not found at the path \"{$path}\"."
 

diff --git a/plugins/importexport/native/filter/SubmissionFileNativeXmlFilter.inc.php b/plugins/importexport/native/filter/SubmissionFileNativeXmlFilter.inc.php
@@ -81,6 +81,13 @@ function createSubmissionFileNode($doc, $submissionFile) {
 		$stageToName[7] = $stageToName[SUBMISSION_FILE_FINAL];
 		// Maps the retired/removed SUBMISSION_FILE_FAIR_COPY to SUBMISSION_FILE_COPYEDIT (see: https://github.com/pkp/pkp-lib/issues/7470)
 		$stageToName[8] = $stageToName[SUBMISSION_FILE_COPYEDIT];
+
+		// Report if no revision has been added
+		if (!isset($stageToName[$submissionFile->getFileStage()])) {
+			$deployment->addWarning(ASSOC_TYPE_SUBMISSION_FILE, $submissionFile->getId(), __('plugins.importexport.native.error.submissionFileInvalidFileStage', ['id' => $submissionFile->getId()]));
+			return null;
+		}
+
 		$genreDao = DAORegistry::getDAO('GenreDAO'); /* @var $genreDao GenreDAO */
 		$genre = $genreDao->getById($submissionFile->getData('genreId'));
 		$userDao = DAORegistry::getDAO('UserDAO'); /* @var $userDao UserDAO */