Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OMP] Language is not included in ONIX export #10641

Closed
kaitlinnewson opened this issue Nov 27, 2024 · 2 comments
Closed

[OMP] Language is not included in ONIX export #10641

kaitlinnewson opened this issue Nov 27, 2024 · 2 comments
Assignees
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone

Comments

@kaitlinnewson
Copy link
Member

Describe the bug
In the ONIX export in OMP, the <Language> is not being populated in ONIX exports.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the ONIX export tool in OMP
  2. Export a published submission
  3. See that the Language is missing in the XML.

What application are you using?
OMP (all versions)

Additional information

@kaitlinnewson kaitlinnewson added this to the 3.3.0-x milestone Nov 27, 2024
@kaitlinnewson kaitlinnewson self-assigned this Nov 27, 2024
@kaitlinnewson kaitlinnewson added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Nov 27, 2024
kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Dec 23, 2024
@kaitlinnewson
Copy link
Member Author

@bozana PRs ready for review:

As part of this PR I also fixed issues I found in the title elements, based on the ONIX documentation about prefixes for titles. It specifies:

"<TitleText> – is reserved for use when the sending system cannot differentiate between titles that include a prefix and titles that do not."

... and so I removed usage of the <TitleText> element since we can differentiate the prefix elements.

For the main branch, I also updated UserGroup based on the recent refactor.

bozana added a commit to pkp/omp that referenced this issue Jan 3, 2025
pkp/pkp-lib#10641 fix onix export language and update title elements …
bozana added a commit to pkp/omp that referenced this issue Jan 3, 2025
pkp/pkp-lib#10641 fix onix export language and update title elements
bozana added a commit to pkp/omp that referenced this issue Jan 3, 2025
pkp/pkp-lib#10641 fix onix export language and update title elements
@bozana
Copy link
Collaborator

bozana commented Jan 3, 2025

Hi @kaitlinnewson, thanks a lot! All merged, thus closing the issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
Status: Done
Development

No branches or pull requests

2 participants