Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#9914 editorial history #9941

Merged
merged 10 commits into from
Jun 11, 2024
Merged

pkp/pkp-lib#9914 editorial history #9941

merged 10 commits into from
Jun 11, 2024

Conversation

bozana
Copy link
Collaborator

@bozana bozana commented May 6, 2024

s. #9914

The PR implements the Editorial History page and fixes a few things for the public Editorial Masthead page:

  • ignores the masthead role = reviewer already in the handler (instead of in the template)
  • orders the users by family name
  • list relevant reviewer's data (affiliation and orcid are added)

@bozana bozana mentioned this pull request May 6, 2024
@bozana bozana force-pushed the 9914 branch 2 times, most recently from 34679f1 to fff2a07 Compare May 14, 2024 10:48
@bozana bozana changed the title pkp/pkp-lib#9914 editorial history public page pkp/pkp-lib#9914 editorial history May 14, 2024
Copy link
Member

@asmecher asmecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments -- thanks, @bozana!

locale/en/manager.po Outdated Show resolved Hide resolved
pages/about/AboutContextHandler.php Outdated Show resolved Hide resolved
templates/frontend/pages/editorialHistory.tpl Outdated Show resolved Hide resolved
templates/frontend/pages/editorialMasthead.tpl Outdated Show resolved Hide resolved
@bozana bozana force-pushed the 9914 branch 2 times, most recently from 6abc77f to fd6b973 Compare June 6, 2024 11:44
@bozana
Copy link
Collaborator Author

bozana commented Jun 6, 2024

Hi @asmecher, could you please review the last commit/changes after the code review?
Thanks a lot!

Copy link
Member

@asmecher asmecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, thanks!

pages/about/AboutContextHandler.php Outdated Show resolved Hide resolved
classes/userGroup/Repository.php Outdated Show resolved Hide resolved
pages/about/AboutContextHandler.php Outdated Show resolved Hide resolved
templates/frontend/pages/editorialHistory.tpl Outdated Show resolved Hide resolved
@bozana
Copy link
Collaborator Author

bozana commented Jun 10, 2024

Hi @asmecher, I have considered the comments. Could you please take a look at the last commit here?
Thanks a lot!

@asmecher
Copy link
Member

That looks great, thanks -- please go ahead!

@bozana bozana merged commit 5d47e0a into pkp:main Jun 11, 2024
1 check passed
@bozana bozana deleted the 9914 branch June 11, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants