Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#10842 Extend DropdownActions component with text button display option #495

Merged
merged 4 commits into from
Jan 28, 2025
Merged

pkp/pkp-lib#10842 Extend DropdownActions component with text button display option #495

merged 4 commits into from
Jan 28, 2025

Conversation

blesildaramirez
Copy link
Collaborator

No description provided.

@blesildaramirez blesildaramirez mentioned this pull request Jan 25, 2025
Closed
jardakotesovec
jardakotesovec approved these changes Jan 26, 2025
View reviewed changes
Copy link
Collaborator

@jardakotesovec jardakotesovec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, only suggestion I would have to use word 'variant' instead of type. As thats what we often use to differentiate different stylings. buttonVariant.

And chromatic deployment is failing.. can you check?

@blesildaramirez blesildaramirez merged commit 5d03195 into pkp:main Jan 28, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jardakotesovec jardakotesovec jardakotesovec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blesildaramirez @jardakotesovec