Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better search for .pscale.yml file #22

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

schacon
Copy link
Contributor

@schacon schacon commented Jan 21, 2024

In the case of monorepos, the .pscale.yml file may not be in the current working directory as the pscale CLI will write it in the Git root. This modifies the search logic to find the git root in the event that the .pscale.yml file is not found in the CWD.

We are checking the use cases that the GIT_DIR is set or the user is in a Git worktree as well.

This addresses #21

In the case of monorepos, the .pscale.yml file may not be in the
current working directory as the pscale CLI will write it in the
Git root. This modifies the search logic to find the git root in
the event that the .pscale.yml file is not found in the CWD.

We are checking the use cases that the GIT_DIR is set or the user
is in a Git worktree as well.
@dgraham dgraham requested a review from mscoutermarsh January 22, 2024 16:05
Copy link
Member

@mscoutermarsh mscoutermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants