Skip to content

Commit

Permalink
in Dockerfile update node version 12 to 18 and remove bower
Browse files Browse the repository at this point in the history
Dockerfile :  NODE_ALPINE_VERSION 12 -> 18, node:12-alpine -> 18, drop : npm install bower and bower install
  • Loading branch information
Don-Isdale committed Mar 25, 2024
1 parent d802eb1 commit d2192e4
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@

# samtools build layer is based on https://hub.docker.com/r/bschiffthaler/samtools/dockerfile

ARG NODE_ALPINE_VERSION 12
ARG NODE_ALPINE_VERSION 18

# ${NODE_ALPINE_VERSION}
FROM node:12-alpine as node-alpine-build-samtools
FROM node:18-alpine as node-alpine-build-samtools

ARG NODE_ALPINE_VERSION 12
ARG NODE_ALPINE_VERSION 18
ARG SAMTOOLS_VERSION=1.15.1
ARG BUILD_NCPU=1

Expand Down Expand Up @@ -74,10 +74,10 @@ WORKDIR /
#-------------------------------------------------------------------------------

# ${NODE_ALPINE_VERSION}
FROM node:12-alpine as node-alpine-pretzel
FROM node:18-alpine as node-alpine-pretzel

ARG PRETZEL_VERSION 2.15.0
ARG NODE_ALPINE_VERSION 12
ARG NODE_ALPINE_VERSION 18

# node-sass version is selected so that the binary can be downloaded;
# otherwise, node-gyp will be built, and hence the following dependencies on python, make, c++.
Expand Down Expand Up @@ -105,8 +105,7 @@ RUN apk add --no-cache git \
terminus-font \
curl \
jq \
openssh \
&& npm install bower -g
openssh


# ------------------------------------------------------------------------------
Expand Down Expand Up @@ -167,7 +166,7 @@ RUN date \


RUN node --version
RUN cd /frontend && (npm ci || npm install) && bower install --allow-root
RUN cd /frontend && (npm ci || npm install)

# RUN cd /app && npm install [email protected] && npm ci

Expand All @@ -177,7 +176,6 @@ RUN ( [ ! -L /app/client ] || rm /app/client ) && \
mv /frontend/dist /app/client \
&& cd / \
&& rm -rf /frontend \
&& npm uninstall -g bower \
&& npm cache clean --force

ENV EMAIL_VERIFY=NONE AUTH=ALL
Expand All @@ -187,7 +185,7 @@ ENTRYPOINT ["/usr/local/node16/bin/node", "/app/lb3app/server/server.js"]

# ------------------------------------------------------------------------------

ARG NODE_ALPINE_VERSION 12
ARG NODE_ALPINE_VERSION 18
ARG SAMTOOLS_VERSION=1.15.1
ARG bcftoolsVer=1.15.1
ARG PRETZEL_VERSION 2.15.0
Expand Down

0 comments on commit d2192e4

Please sign in to comment.