remove active_material from dependency (break changes) #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to merge #265 before this |
cprodhomme
force-pushed
the
organise-custom-theme-for-addons
branch
from
e095835 to
8c29f62
Compare
|
@cprodhomme I'm not sure if I understood the idea. Are you proposing to remove the gem from the dependencies as it is not used by default, and that we should make the user responsible of including it if needed? If that's the idea, I like it but, as you say, it's breaking. If we merge this, we should release it in version 2.0 |
cprodhomme
force-pushed
the
organise-custom-theme-for-addons
branch
from
8c29f62 to
fedc0c5
Compare
|
+10 for this, lot of other gems follow this pattern. Also the same should be done for |
|
closing this, as active_material has been removed in v2 beta. More details here. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i don't use
active_materialand i think it's sad to implement this gem for no reasoninfortunatly, this is a break changes
what do you think about this idea ?