Webpacker

[gmq]

Add support for ActiveAdmin in webpacker mode. (#298)

• Uses rollup to generate the javascript used by sprockets
• Updates javascript files to use es6 imports.
• Adds generators to include the appropriate files when installing depending on how ActiveAdmin was installed.

TODO:

• It assumes the npm package is going to be named "activeadmin_addons" How are we going to handle that release?
• Tests
• Potassium support will be handled separately.

For testing:

• Clone this branch
• Run yarn prepublishOnly inside cloned folder
• In a new Rails installation add activeadmin and add this gem locally
  gem 'activeadmin_addons', path: '../activeadmin_addons'
• Install activeadmin in webpacker mode
  bundle exec rails g active_admin:install --use_webpacker
• Install activeadmin addons
  bundle exec rails g activeadmin_addons:install
  (ignore yarn error)
• Install npm package
  yarn add ../activeadmin_addons

[monkeyci]

Avoid rescuing without specifying an error class.

[monkeyci]

Avoid rescuing without specifying an error class.

[filipkis]

Thanks @gmq for this PR. Any update on this? What's still needed for it to get merged and released?

[nimarosa]

+1 Any updates on this? Can it be merged? I Am willing to help if anything is still needed.

[hgeorgilas]

Is this going to be merged soon?
Thanks

[guiferrpereira]

excellent work here. can you tell when this will be merged?

[gmq]

I can't give a specific timeline, it still needs to be reviewed by the team and time is scarce these days. But it should be sooner rather than later!

[kwent]

Looking forward to this ! Much needed !

[kwent]

@gmq @rjherrera Thanks for the amazing work! Looks like it's very close to the finish line. How can we help ? Regards

[dkniffin]

@gmq Great work on this! I'd love to start using it. What are we waiting on to merge? A review from @hidalgoegz ?

[gmq]

We're ready to merge to master!

We'd appreciate any bug reports or other feedback about this so if you'd like to test it before we make a new release, please add the following to your Gemfile:

gem 'activeadmin_addons', git: 'https://github.com/platanus/activeadmin_addons'

[agrobbin]

@gmq this is great! Out of curiosity, are there also plans to remove the hard runtime dependency on sassc and sassc-rails from the gemspec? Active Admin just did that as well.

[djalmaaraujo]

@gmq I can't make it work on activeadmin latest version. Just says activeadmin_addons/all cannot be found. yarn was added, etc. Javascript file is imported but SCSS does not work even with sass-rails on the gemfile.

[jasonperrone]

I'm concerned about the comment on this change "if ActiveAdmin was installed in that mode". What about the situation where ActiveAdmin was not installed in that mode, but was later changed to use webpacker?

[matiasgarcia]

Same as @djalmaaraujo I can't make it work.

Node module is:

I tried doing @import "activeadmin_addons" instead of @import "activeadmin_addons/all" and now I get this error:

ERROR in ./app/javascript/stylesheets/active_admin.scss (./node_modules/css-loader/dist/cjs.js??ref--6-1!./node_modules/postcss-loader/src??ref--6-2!./node_modules/sass-loader/dist/cjs.js??ref--6-3!./app/javascript/stylesheets/active_admin.scss)
Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: Invalid CSS after "i": expected 1 selector or at-rule, was "import 'select2';"
        on line 1 of node_modules/activeadmin_addons/src/all.js
        from line 13 of /home/mgarcia/projects/withdrawals/app/javascript/stylesheets/active_admin.scss
>> import 'select2';

Which fails in the first line of all.scss that does:

@import 'select2';

[gmq]

@gmq I can't make it work on activeadmin latest version. Just says activeadmin_addons/all cannot be found. yarn was added, etc. Javascript file is imported but SCSS does not work even with sass-rails on the gemfile.

Same as @djalmaaraujo I can't make it work.

I just merged a fix by @ParamagicDev for the documentation. The proper way to import the scss is to use @import 'activeadmin_addons/src/stylesheets/all';

I'm concerned about the comment on this change "if ActiveAdmin was installed in that mode". What about the situation where ActiveAdmin was not installed in that mode, but was later changed to use webpacker?

It checks config.use_webpacker in the Active Admin initializer so the addons generator should make the appropriate changes as long as it's enabled there.