Add rancher_registration_token resource type #3
Conversation
|
hey @raphink awesome! thanks! I think now I can rebase the registry branch from yours, and make it work.. :) |
Refactor config.go to allow for environment clients to be created
|
@blackjid Ah, hadn't seen your registry branch, sorry! Reorganizing this client thing to get Environment-specific clients was a pain, but required anyway for most resource types (registry, registration_token, stack, etc.) I just rebased the PR now that you merged the other one. |
|
|
||
| #### Example Usage | ||
|
|
||
| ``` |
There was a problem hiding this comment.
what about using the hcl highlighting now you proposed that on the rest of the docs ?
There was a problem hiding this comment.
Yes, I was waiting for you to merge the other PR first.
| value = "${rancher_registration_token.registration_url}" | ||
| } | ||
|
|
||
| output "registration_token" { |
There was a problem hiding this comment.
do you think is necessary to add the outputs to the example??
If we do that will end up repeating all the attributes in the attributes references here in the example...
There was a problem hiding this comment.
OK, I can remove those.
| } | ||
|
|
||
| func resourceRancherRegistrationTokenDelete(d *schema.ResourceData, meta interface{}) error { | ||
| log.Printf("[INFO] Deleting RegistrationToken is not possible, simply removing its ID: %s", d.Id()) |
There was a problem hiding this comment.
what do you mean with this line of log?
At the end you are effectively deleting the token right?? after deactivating it...
There was a problem hiding this comment.
My bad. I couldn't get deleting to work at first, so I had put this. I've now found how to deactivate/remove, so I can remove this.
|
don't worry I had the branch, but some stuff were just in my computer, i've just push them... |
|
@blackjid there you go, I fixed all your comments. |
Refactor config.go to allow for environment clients to be created