Rename "misc" command to "system", do not append completion code for …

…Fish shell // Resolve 3435
platformio · May 23, 2020 · 7dce494 · 7dce494
1 parent 4921bf8
commit 7dce494
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/docs b/docs
diff --git a/platformio/commands/misc/__init__.py → platformio/commands/system/__init__.py b/platformio/commands/misc/__init__.py → platformio/commands/system/__init__.py
diff --git a/platformio/commands/misc/command.py → platformio/commands/system/command.py b/platformio/commands/misc/command.py → platformio/commands/system/command.py
@@ -18,14 +18,14 @@
 import click
 
 from platformio import proc
-from platformio.commands.misc.completion import (
+from platformio.commands.system.completion import (
     get_completion_install_path,
     install_completion_code,
     uninstall_completion_code,
 )
 
 
-@click.group("misc", short_help="Miscellaneous commands")
+@click.group("system", short_help="Miscellaneous system commands")
 def cli():
     pass
 

diff --git a/platformio/commands/misc/completion.py → platformio/commands/system/completion.py b/platformio/commands/misc/completion.py → platformio/commands/system/completion.py
@@ -52,7 +52,7 @@ def install_completion_code(shell, path):
     if is_completion_code_installed(shell, path):
         return None
 
-    return click_completion.install(shell=shell, path=path)
+    return click_completion.install(shell=shell, path=path, append=shell != "fish")
 
 
 def uninstall_completion_code(shell, path):

diff --git a/tox.ini b/tox.ini
@@ -19,7 +19,7 @@ envlist = py27,py37,py38
 passenv = *
 usedevelop = True
 deps =
-    py36,py3,py38: black
+    py36,py37,py38: black
     isort
     pylint
     pytest
+3 −3		core/userguide/account/index.rst
+2 −2		core/userguide/index.rst
+0 −0		core/userguide/system/completion/cmd_install.rst
+0 −0		core/userguide/system/completion/cmd_uninstall.rst
+0 −0		core/userguide/system/completion/index.rst
+7 −7		core/userguide/system/index.rst