Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework error and debug handling #228

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Rework error and debug handling #228

merged 1 commit into from
Jan 15, 2025

Conversation

pjcdawkins
Copy link
Contributor

@pjcdawkins pjcdawkins commented Jan 3, 2025

Choices:

  • Do not silence Cobra errors
  • Remove stdlib log use
  • Make debug logging consistent with legacy CLI format
  • Consistently use Cobra command output writers, and make them colorable when possible

Rationale:

- Do not silence Cobra errors
- Remove stdlib log use
- Make debug logging consistent with legacy CLI format
- Consistently use Cobra command output writers, rather than bypassing them with color.Error
Copy link
Member

@akalipetis akalipetis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akalipetis akalipetis merged commit 9df870d into main Jan 15, 2025
1 check passed
@akalipetis akalipetis deleted the error-handling branch January 15, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants