Fix #167: Missing locations root leads to 500 once the app is deployed #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Oct 3, 2023
akalipetis
added a commit
to platformsh/cli
that referenced
this pull request
Oct 26, 2023
Release notes: * Fix #167: Missing locations root leads to 500 once the app is deployed by @lolautruche in platformsh/platformify#168 * Bump Node default version to 20 by @lolautruche in platformsh/platformify#172 * Name is about application, not project by @lolautruche in platformsh/platformify#173 * Skip empty files when generating by @akalipetis in platformsh/platformify#179 * Fix Laravel database and n handling by @akalipetis in platformsh/platformify#180 * Add more Strapi-specific environment variables by @akalipetis in platformsh/platformify#181
pjcdawkins
pushed a commit
to platformsh/cli
that referenced
this pull request
Oct 26, 2023
Release notes: * Fix #167: Missing locations root leads to 500 once the app is deployed by @lolautruche in platformsh/platformify#168 * Bump Node default version to 20 by @lolautruche in platformsh/platformify#172 * Name is about application, not project by @lolautruche in platformsh/platformify#173 * Skip empty files when generating by @akalipetis in platformsh/platformify#179 * Fix Laravel database and n handling by @akalipetis in platformsh/platformify#180 * Add more Strapi-specific environment variables by @akalipetis in platformsh/platformify#181
pjcdawkins
added a commit
to platformsh/cli
that referenced
this pull request
Oct 26, 2023
* Bump Platformify to v0.2.4 Release notes: * Fix #167: Missing locations root leads to 500 once the app is deployed by @lolautruche in platformsh/platformify#168 * Bump Node default version to 20 by @lolautruche in platformsh/platformify#172 * Name is about application, not project by @lolautruche in platformsh/platformify#173 * Skip empty files when generating by @akalipetis in platformsh/platformify#179 * Fix Laravel database and n handling by @akalipetis in platformsh/platformify#180 * Add more Strapi-specific environment variables by @akalipetis in platformsh/platformify#181 --------- Co-authored-by: Patrick Dawkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now if no
index.phpcan be found,locations.rootdefaults to""