Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Timex from Plausible.Timezones #3899

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Remove Timex from Plausible.Timezones #3899

merged 2 commits into from
Sep 5, 2024

Conversation

ruslandoga
Copy link
Contributor

@ruslandoga ruslandoga commented Mar 15, 2024

Continues #4338

Changes

This PR continues the removal of Timex by updating Plausible.Timezones to use stdlib instead of Timex.

This includes:

Unlike the previous PRs this one requires updates to the tests since Timex logic is wrong:

Tests

  • Automated tests have been updated

Changelog

  • No need to update changelog.

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@ruslandoga ruslandoga requested a review from a team March 15, 2024 01:54
@ruslandoga ruslandoga changed the title Fix timezones (?) Fix to_utc_datetime (?) Mar 15, 2024
@ruslandoga ruslandoga mentioned this pull request Mar 15, 2024
4 tasks
@ruslandoga ruslandoga mentioned this pull request Mar 19, 2024
4 tasks
@ruslandoga ruslandoga changed the title Fix to_utc_datetime (?) fix to_utc_datetime May 24, 2024
@ruslandoga ruslandoga marked this pull request as draft August 23, 2024 07:28
@ruslandoga ruslandoga force-pushed the fix-timezones branch 5 times, most recently from 6ff48f1 to abf2b69 Compare August 23, 2024 08:56
@ruslandoga ruslandoga changed the title fix to_utc_datetime Remove Timex from Plausible.Timezones Aug 23, 2024
@ruslandoga ruslandoga marked this pull request as ready for review August 23, 2024 09:00
@ruslandoga ruslandoga requested a review from a team August 23, 2024 09:00
Copy link

Preview environment👷🏼‍♀️🏗️
PR-3899

@zoldar zoldar merged commit 654558d into master Sep 5, 2024
10 checks passed
@zoldar zoldar deleted the fix-timezones branch September 5, 2024 09:48
@ruslandoga ruslandoga mentioned this pull request Sep 7, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants