-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Timex from Plausible.Timezones #3899
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
commented
Mar 15, 2024
57258c6
to
d88722a
Compare
aerosol
reviewed
Mar 15, 2024
ruslandoga
commented
Mar 16, 2024
ruslandoga
commented
Mar 16, 2024
ruslandoga
commented
Mar 16, 2024
6ff48f1
to
abf2b69
Compare
|
abf2b69
to
ef6a05b
Compare
zoldar
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #4338
Changes
This PR continues the removal of Timex by updating
Plausible.Timezones
to use stdlib instead of Timex.This includes:
Unlike the previous PRs this one requires updates to the tests since Timex logic is wrong:
Tests
Changelog
Documentation
Dark mode