Stop segment queries when not needed #5043
Merged
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apata
force-pushed
the
stop-segment-queries-when-not-needed
branch
from
d173dd9 to
b76118e
Compare
apata
force-pushed
the
stop-segment-queries-when-not-needed
branch
from
b76118e to
bf8f589
Compare
ukutaht
reviewed
Feb 3, 2025
| @@ -39,7 +39,13 @@ defmodule Plausible.Segments do | |||
|
|
|||
| @spec get_many(Plausible.Site.t(), list(pos_integer()), Keyword.t()) :: | |||
| {:ok, [Segment.t()]} | |||
| def get_many(%Plausible.Site{} = site, segment_ids, opts) when is_list(segment_ids) do | |||
| def get_many(%Plausible.Site{} = _site, segment_ids, _opts) | |||
There was a problem hiding this comment.
I think pattern matching directly instead of using when would work here (?)
def get_many(%Plausible.Site{} = _site, [], _opts) do
ukutaht
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When investigating some traces, we found that there's more database queries happening than needed. This removes one of them, which was running on all stats requests.
Tests
Changelog
Documentation
Dark mode